Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: disable class def rendering #7329

Merged
merged 1 commit into from
Mar 7, 2024
Merged

docs: disable class def rendering #7329

merged 1 commit into from
Mar 7, 2024

Conversation

wochinge
Copy link
Contributor

@wochinge wochinge commented Mar 7, 2024

Proposed Changes

  • disable class def in readme

Old
Screenshot 2024-03-06 at 13 21 30

New
Screenshot 2024-03-06 at 13 21 06

@wochinge wochinge requested a review from a team as a code owner March 7, 2024 12:47
@wochinge wochinge requested review from davidsbatista and shadeMe and removed request for a team March 7, 2024 12:47
@github-actions github-actions bot added the 2.x Related to Haystack v2.0 label Mar 7, 2024
davidsbatista
davidsbatista approved these changes Mar 7, 2024
View reviewed changes
Copy link
Contributor

@davidsbatista davidsbatista left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shadeMe shadeMe merged commit a3a2194 into main Mar 7, 2024
9 checks passed
@shadeMe shadeMe deleted the docs/disable-class-def branch March 7, 2024 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidsbatista davidsbatista davidsbatista approved these changes

@shadeMe shadeMe shadeMe approved these changes

Assignees
No one assigned
Labels
2.x Related to Haystack v2.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wochinge @shadeMe @davidsbatista